Skip to content
This repository has been archived by the owner on Nov 16, 2024. It is now read-only.

Announcing rewrite of the Library Carpentry Intro to Python lesson #1830

Merged
merged 12 commits into from
Jun 27, 2024

Conversation

jt14den
Copy link
Contributor

@jt14den jt14den commented Jun 7, 2024

Blog on updated lc python lesson.

Blog on updated lc python lesson
@tobyhodges tobyhodges requested a review from OscarSiba June 13, 2024 09:06
@OscarSiba
Copy link
Contributor

Blog on updated lc python lesson.

Hi @jt14den, please hit ‘accept suggestion’ (and not ‘resolve’) for all suggestions you are happy to be incorporated into the final blog post. Most suggestions are changes from American to UK English spelling as per Carpentries style guide.

@OscarSiba
Copy link
Contributor

Blog on updated lc python lesson.

Hi @jt14den, please hit ‘accept suggestion’ (and not ‘resolve’) for all suggestions you are happy to be incorporated into the final blog post. Most suggestions are changes from American to UK English spelling as per Carpentries style guide.

Pinging you again @jt14den to check if you would be able to update this this week so we can publish it sometime during the week? Please update publication date to also reflect when it would be ready to go out.

@jt14den
Copy link
Contributor Author

jt14den commented Jun 25, 2024

@OscarSiba i'm not seeing anything to update on my end. Can you lmk what I need to do to move this forward? Thanks

Copy link
Contributor

@OscarSiba OscarSiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @jt14den, @tobyhodges just made me realise I didn't actually submit my review, and it's been pending on my side all this time! Hope you see the suggested changes now!

_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
_posts/2024/06/2024-06-15-lc-python-update.md Outdated Show resolved Hide resolved
@jt14den
Copy link
Contributor Author

jt14den commented Jun 27, 2024

@OscarSiba think this is good to go, but some deploy tests failed.

@OscarSiba
Copy link
Contributor

@OscarSiba think this is good to go, but some deploy tests failed.

Thank you @jt14den. Yes, there's been some problems with Netlify workflows for some time now, but all looks ok so we will merge.

@OscarSiba OscarSiba merged commit 508c945 into carpentries:main Jun 27, 2024
1 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants